Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ory stack configs #930

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Add Ory stack configs #930

merged 6 commits into from
Aug 14, 2024

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Aug 13, 2024

Description:

  • Updates existing kratos config
  • Adds new Ory components: radar-self-enrolment-ui and hydra
  • Also has the Kratos -> MP webhook configs
  • Docker image for self-enrolment UI is here temporarily: mpgxvii/radar-self-enrolment-ui:latest

Checklist:

  • The Main workflow has succeeded
  • The Gatling tests have passed
  • I have logged into the portal running locally with default admin credentials
  • I have updated the README files if this change requires documentation update
  • I have commented my code, particularly in hard-to-understand areas

@Bdegraaf1234
Copy link
Member

I am seeing other PRs merge into this branch, which will be merged into dev here, is that what we want? If we merge this after merging the other PRs we will break the current flow, as they require hydra.

I would say we merge into one of the two feature branches for hydra/ory

@mpgxvii mpgxvii changed the base branch from dev to feature/ory-based-authorization August 14, 2024 10:55
yatharthranjan
yatharthranjan approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I have updated to use a single instance of Postgres for both Kratos and Hydra in an effort to reduce the resource load for local dev and testing.

BTW, I am getting a csrf security violation when signing up (http 403). I assume that is because the enrolment ui docker image is not up to date with you latest changes?

@mpgxvii
Copy link
Member Author

mpgxvii commented Aug 14, 2024

I am seeing other PRs merge into this branch, which will be merged into dev here, is that what we want? If we merge this after merging the other PRs we will break the current flow, as they require hydra.

I would say we merge into one of the two feature branches for hydra/ory

@Bdegraaf1234 @yatharthranjan Yes sure, I've updated it now to merge to feature/ory-based-authorization.

@yatharthranjan yatharthranjan merged commit e1cdee9 into feature/ory-based-authorization Aug 14, 2024
3 of 5 checks passed
@Bdegraaf1234 Bdegraaf1234 deleted the hydra-kratos-stack branch August 19, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan approved these changes

@nivemaham nivemaham Awaiting requested review from nivemaham nivemaham is a code owner

@Bdegraaf1234 Bdegraaf1234 Awaiting requested review from Bdegraaf1234 Bdegraaf1234 is a code owner

@peyman-mohtashami peyman-mohtashami Awaiting requested review from peyman-mohtashami peyman-mohtashami is a code owner

@pvannierop pvannierop Awaiting requested review from pvannierop pvannierop is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpgxvii @Bdegraaf1234 @yatharthranjan